Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@edoedac0 doesnt need to be a setting, we should use this instead of the white bg, but I think we need to make sure every icon looks good on light and dark mode. In your screenshot zed needs to be the dark mode version of their icon. Will need to support two versions for some of these (light and dark).

@edoedac0 doesnt need to be a setting, we should use this instead of the white bg, but I think we need to make sure every icon looks good on light and dark mode. In your screenshot zed needs to be the dark mode version of their icon. Will need to support two versions for some of these (light and dark).

yeah ur right, i will make a new commit soon with two versions for some icons that need it

@edoedac0 doesnt need to be a setting, we should use this instead of the white bg, but I think we need to make sure every icon looks good on light and dark mode. In your screenshot zed needs to be the dark mode version of their icon. Will need to support two versions for some of these (light and dark).

Here, I also updated finder icon to the tahoe version for all users with macos tahoe

@edoedac0 sorry, last request: let's just use the Tahoe icon always for finder, removes a bunch of complexity

@edoedac0 sorry, last request: let's just use the Tahoe icon always for finder, removes a bunch of complexity

No problem, here it is

btw @adamdotdevin what do you think about this pr #12722 ?

@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge

btw @adamdotdevin what do you think about this pr #12722 ?

Love it

/oc remove the conditional nature of this improvement, we should always use transparent images, please remove the changes to settings, locale changes, etc, clean it all up

All changes have been applied successfully. Let me provide a summary of what was cleaned up:

Summary

Removed the conditional "transparent app icons" setting and made transparent images the default behavior:

1. packages/app/src/context/settings.tsx: Removed transparentAppIcons from the Settings interface, default settings, and the settings context provider.

2. packages/app/src/components/settings-general.tsx: Removed the toggle switch UI for the transparent app icons setting.

3. packages/app/src/i18n/en.ts: Removed the locale strings for the transparent app icons setting title and description.

4. packages/app/src/components/session/session-header.tsx:

   • Removed the useSettings import
   • Removed the settings variable
   • Removed the appIconStyle computed memo
   • Removed the style={appIconStyle()} prop from both AppIcon usages

5. packages/ui/src/components/app-icon.css: Removed the padding, border-radius, background, and border styles that created the framed appearance. Now app icons display transparently by default.

opencode session  |  github run

@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge

Sorry I wasn't on pc, my bad I forgot to push that. Do I still need to or the bot took care of it?

btw @adamdotdevin what do you think about this pr #12722 ?

Love it

Greatt, is it good for merging?

@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge

Sorry I wasn't on pc, my bad I forgot to push that. Do I still need to or the bot took care of it?

Could you test and make sure it still looks good? Also, I think it touched the English locale file still, could you remove that change?

@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge

Sorry I wasn't on pc, my bad I forgot to push that. Do I still need to or the bot took care of it?

Could you test and make sure it still looks good? Also, I think it touched the English locale file still, could you remove that change?

yeah

@edoedac0 please remove the setting, we'll just always have transparent icons, please clean all that up and I'll merge

Sorry I wasn't on pc, my bad I forgot to push that. Do I still need to or the bot took care of it?

Could you test and make sure it still looks good? Also, I think it touched the English locale file still, could you remove that change?

everything looks good on my end, for the english file it just removed:

• settings.general.row.transparentAppIcons.title
• settings.general.row.transparentAppIcons.description